lkml.org 
[lkml]   [2016]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/6] mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbered_child()
    On Sun, 26 Jun 2016, SF Markus Elfring wrote:

    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Sun, 26 Jun 2016 12:25:36 +0200

    Please use `git send-email` when sending patches to the list.

    > The platform_device_put() function was called in one case by the
    > add_numbered_child() function during error handling even if the passed
    > variable "pdev" contained a null pointer.
    > Return directly in this case.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > drivers/mfd/twl-core.c | 7 ++-----
    > 1 file changed, 2 insertions(+), 5 deletions(-)

    Applied though, thanks.

    > diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
    > index 831696e..9458c6d 100644
    > --- a/drivers/mfd/twl-core.c
    > +++ b/drivers/mfd/twl-core.c
    > @@ -622,11 +622,8 @@ add_numbered_child(unsigned mod_no, const char *name, int num,
    > twl = &twl_priv->twl_modules[sid];
    >
    > pdev = platform_device_alloc(name, num);
    > - if (!pdev) {
    > - dev_dbg(&twl->client->dev, "can't alloc dev\n");
    > - status = -ENOMEM;
    > - goto err;
    > - }
    > + if (!pdev)
    > + return ERR_PTR(-ENOMEM);
    >
    > pdev->dev.parent = &twl->client->dev;
    >

    --
    Lee Jones
    Linaro STMicroelectronics Landing Team Lead
    Linaro.org │ Open source software for ARM SoCs
    Follow Linaro: Facebook | Twitter | Blog

    \
     
     \ /
      Last update: 2016-06-28 17:41    [W:4.271 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site