Messages in this thread | | | Date | Tue, 28 Jun 2016 10:54:34 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH v5] tools/perf: Fix the mask in regs_dump__printf and print_sample_iregs |
| |
On Thu, Jun 23, 2016 at 11:19:27AM +0530, Madhavan Srinivasan wrote:
SNIP
> > Changelog v1: > 1)updated commit message and patch subject > 2)Add the fix to print_sample_iregs() in builtin-script.c > > tools/include/linux/bitmap.h | 2 ++ > tools/lib/bitmap.c | 18 ++++++++++++++++++ > tools/perf/builtin-script.c | 4 +++- > tools/perf/util/session.c | 4 +++- > 4 files changed, 26 insertions(+), 2 deletions(-) > > diff --git a/tools/include/linux/bitmap.h b/tools/include/linux/bitmap.h > index 28f5493da491..5e98525387dc 100644 > --- a/tools/include/linux/bitmap.h > +++ b/tools/include/linux/bitmap.h > @@ -2,6 +2,7 @@ > #define _PERF_BITOPS_H > > #include <string.h> > +#include <limits.h>
this could go in the bitmap.c file, but anyway:
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks, jirka
> #include <linux/bitops.h> > > #define DECLARE_BITMAP(name,bits) \ > @@ -10,6 +11,7 @@ > int __bitmap_weight(const unsigned long *bitmap, int bits); > void __bitmap_or(unsigned long *dst, const unsigned long *bitmap1, > const unsigned long *bitmap2, int bits); > +void bitmap_from_u64(unsigned long *dst, u64 mask); > > #define BITMAP_FIRST_WORD_MASK(start) (~0UL << ((start) & (BITS_PER_LONG - 1))) >
SNIP
| |