lkml.org 
[lkml]   [2016]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v10 03/22] IB/hns: Add initial main frame driver and get cfg info
From
Date


On 2016/6/27 15:00, Leon Romanovsky wrote:
> On Sat, Jun 25, 2016 at 06:29:31PM +0800, Wei Hu (Xavier) wrote:
>>
>> On 2016/6/24 19:48, Leon Romanovsky wrote:
>>> On Thu, Jun 16, 2016 at 10:35:11PM +0800, Lijun Ou wrote:
>>>> This patch mainly added the initial bare main driver. It
>>>> could get the relative configure information of net node.
>>>>
>>>> Signed-off-by: Wei Hu <xavier.huwei@huawei.com>
>>>> Signed-off-by: Nenglong Zhao <zhaonenglong@hisilicon.com>
>>>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>>>> ---
> ...
>
>>>> + return -ENOMEM;
>>>> +
>>>> + for (i = 0; i < HNS_ROCE_MAX_PORTS; i++) {
>>>> + net_node = of_parse_phandle(np, "eth-handle", i);
>>>> + if (net_node) {
>>>> + pdev = of_find_device_by_node(net_node);
>>>> + netdev = platform_get_drvdata(pdev);
>>>> + phy_port = (u8)i;
>>>> + if (netdev) {
>>>> + hr_dev->iboe.netdevs[port_cnt] = netdev;
>>>> + hr_dev->iboe.phy_port[port_cnt] = phy_port;
>>>> + } else {
>>>> + return -ENODEV;
>>>> + }
>>>> + port_cnt++;
>>>> + }
>>>> + }
>>> Do you want to check port_cnt value, before continue?
>> Hi, Leon
>> Maybe we need not to check port_cnt value.
>> port_cnt can be ensured smaller than HNS_ROCE_MAX_PORTS.
> You can in theory to get port_cnt == 0, in such case it is wise to
> return error.
I see.

Thanks
Wei Hu


\
 
 \ /
  Last update: 2016-06-27 10:01    [W:1.537 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site