lkml.org 
[lkml]   [2016]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] notifier: Fix soft lockup for notifier_call_chain().
From
Date
On 2016/6/28 3:50, Cong Wang wrote:
> On Fri, Jun 24, 2016 at 7:46 PM, Ding Tianhong <dingtianhong@huawei.com> wrote:
>> diff --git a/kernel/notifier.c b/kernel/notifier.c
>> index fd2c9ac..9c30411 100644
>> --- a/kernel/notifier.c
>> +++ b/kernel/notifier.c
>> @@ -92,6 +92,8 @@ static int notifier_call_chain(struct notifier_block **nl,
>> #endif
>> ret = nb->notifier_call(nb, val, v);
>>
>> + cond_resched();
>> +
>> if (nr_calls)
>> (*nr_calls)++;
>
> NAK.
>
> You can't do a resched in atomic context in __atomic_notifier_call_chain().
>
>
Sorry, I miss this, so I think add touch_nmi_watchdog looks like the best solution for this problem.

Thanks
Ding




\
 
 \ /
  Last update: 2016-06-28 06:01    [W:0.039 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site