Messages in this thread | | | Subject | Re: [PATCH 1/1] usb: dwc2: add printf attribute to cat_printf() | From | John Youn <> | Date | Mon, 27 Jun 2016 18:59:08 -0700 |
| |
On 6/26/2016 1:12 AM, Nicolas Iooss wrote: > As cat_printf() uses printf format strings in its parameters, adding > __printf attribute allows the compiler to detect at compile-time some > errors related to format strings (with -Wformat warning flag). > > Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org> > --- > drivers/usb/dwc2/hcd_queue.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc2/hcd_queue.c b/drivers/usb/dwc2/hcd_queue.c > index b5c7793a2df2..13754353251f 100644 > --- a/drivers/usb/dwc2/hcd_queue.c > +++ b/drivers/usb/dwc2/hcd_queue.c > @@ -367,7 +367,8 @@ static void pmap_unschedule(unsigned long *map, int bits_per_period, > * @fmt: The format for printf. > * @...: The args for printf. > */ > -static void cat_printf(char **buf, size_t *size, const char *fmt, ...) > +static __printf(3, 4) > +void cat_printf(char **buf, size_t *size, const char *fmt, ...) > { > va_list args; > int i; >
Acked-by: John Youn <johnyoun@synopsys.com>
John
| |