Messages in this thread | | | Date | Mon, 27 Jun 2016 10:54:03 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v4 01/29] bluetooth: Switch SMP to crypto_cipher_encrypt_one() |
| |
* Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Andy, > > > SMP does ECB crypto on stack buffers. This is complicated and > > fragile, and it will not work if the stack is virtually allocated. > > > > Switch to the crypto_cipher interface, which is simpler and safer. > > > > Cc: Marcel Holtmann <marcel@holtmann.org> > > Cc: Gustavo Padovan <gustavo@padovan.org> > > Cc: Johan Hedberg <johan.hedberg@gmail.com> > > Cc: "David S. Miller" <davem@davemloft.net> > > Cc: linux-bluetooth@vger.kernel.org > > Cc: netdev@vger.kernel.org > > Acked-by: Herbert Xu <herbert@gondor.apana.org.au> > > Acked-and-tested-by: Johan Hedberg <johan.hedberg@intel.com> > > Signed-off-by: Andy Lutomirski <luto@kernel.org> > > --- > > net/bluetooth/smp.c | 67 ++++++++++++++++++++++------------------------------- > > 1 file changed, 28 insertions(+), 39 deletions(-) > > patch has been applied to bluetooth-next tree.
Sadly carrying this separately will delay the virtual kernel stacks feature by a kernel cycle, because it's a must-have prerequisite.
Thanks,
Ingo
| |