lkml.org 
[lkml]   [2016]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 11/21] usb: chipidea: msm: Use hw_write_id_reg() instead of writel directly
    Date
    The MSM_USB_BASE macro trick is not very clear, and we're using
    it for only one register write so let's just move to using
    hw_write_id_reg() and passing the ci pointer instead. That
    clearly shows what offset we're using and avoids needing to
    include the msm_hsusb_hw.h file when we're going to delete that
    file soon.

    Cc: Peter Chen <peter.chen@nxp.com>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
    ---
    drivers/usb/chipidea/ci_hdrc_msm.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c
    index 37591a4b1346..520c85e701ef 100644
    --- a/drivers/usb/chipidea/ci_hdrc_msm.c
    +++ b/drivers/usb/chipidea/ci_hdrc_msm.c
    @@ -8,14 +8,12 @@
    #include <linux/module.h>
    #include <linux/platform_device.h>
    #include <linux/pm_runtime.h>
    -#include <linux/usb/msm_hsusb_hw.h>
    -#include <linux/usb/ulpi.h>
    #include <linux/usb/gadget.h>
    #include <linux/usb/chipidea.h>

    #include "ci.h"

    -#define MSM_USB_BASE (ci->hw_bank.abs)
    +#define HS_PHY_AHB_MODE 0x0098

    static void ci_hdrc_msm_notify_event(struct ci_hdrc *ci, unsigned event)
    {
    @@ -25,7 +23,7 @@ static void ci_hdrc_msm_notify_event(struct ci_hdrc *ci, unsigned event)
    case CI_HDRC_CONTROLLER_RESET_EVENT:
    dev_dbg(dev, "CI_HDRC_CONTROLLER_RESET_EVENT received\n");
    /* use AHB transactor, allow posted data writes */
    - writel(0x8, USB_AHBMODE);
    + hw_write_id_reg(ci, HS_PHY_AHB_MODE, 0xffffffff, 0x8);
    usb_phy_init(ci->usb_phy);
    break;
    case CI_HDRC_CONTROLLER_STOPPED_EVENT:
    --
    2.9.0.rc2.8.ga28705d
    \
     
     \ /
      Last update: 2016-06-26 10:21    [W:4.050 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site