lkml.org 
[lkml]   [2016]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 01/24] vfs: Add current_time() api
    Date
    current_fs_time() is used for inode timestamps.

    Change the signature of the function to take inode pointer
    instead of superblock as per Linus's suggestion.

    Also, move the api under vfs as per the discussion on the
    thread: https://lkml.org/lkml/2016/6/9/36 . As per Arnd's
    suggestion on the thread, changing the function name.

    current_fs_time() will be deleted after all the references
    to it are replaced by current_time().

    There was a bug reported by kbuild test bot with the change
    as some of the calls to current_time() were made before the
    super_block was initialized. Catch these accidental assignments
    as timespec_trunc() does for wrong granularities. This allows
    for the function to work right even in these circumstances.
    But, adds a warning to make the user aware of the bug.

    A coccinelle script was used to identify all the current
    .alloc_inode super_block callbacks that updated inode timestamps.
    proc filesystem was the only one that was modifying inode times
    as part of this callback. The series includes a patch to fix that.

    Note that timespec_trunc() will also be moved to fs/inode.c
    in a separate patch when this will need to be revamped for
    bounds checking purposes.

    Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
    ---
    fs/inode.c | 23 +++++++++++++++++++++++
    include/linux/fs.h | 1 +
    2 files changed, 24 insertions(+)

    diff --git a/fs/inode.c b/fs/inode.c
    index e171f7b..80b6898 100644
    --- a/fs/inode.c
    +++ b/fs/inode.c
    @@ -2043,3 +2043,26 @@ void inode_nohighmem(struct inode *inode)
    mapping_set_gfp_mask(inode->i_mapping, GFP_USER);
    }
    EXPORT_SYMBOL(inode_nohighmem);
    +
    +/**
    + * current_time - Return FS time
    + * @inode: inode.
    + *
    + * Return the current time truncated to the time granularity supported by
    + * the fs.
    + *
    + * Note that inode and inode->sb cannot be NULL.
    + * Otherwise, the function warns and returns time without truncation.
    + */
    +struct timespec current_time(struct inode *inode)
    +{
    + struct timespec now = current_kernel_time();
    +
    + if (unlikely(!inode->i_sb)) {
    + WARN(1, "current_time() called with uninitialized super_block in the inode");
    + return now;
    + }
    +
    + return timespec_trunc(now, inode->i_sb->s_time_gran);
    +}
    +EXPORT_SYMBOL(current_time);
    diff --git a/include/linux/fs.h b/include/linux/fs.h
    index c4ab2cf..d0d9b38 100644
    --- a/include/linux/fs.h
    +++ b/include/linux/fs.h
    @@ -1476,6 +1476,7 @@ struct super_block {
    };

    extern struct timespec current_fs_time(struct super_block *sb);
    +extern struct timespec current_time(struct inode *inode);

    static inline struct timespec current_fs_time_sec(struct super_block *sb)
    {
    --
    1.9.1
    \
     
     \ /
      Last update: 2016-06-26 00:21    [W:4.053 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site