Messages in this thread | | | Date | Fri, 24 Jun 2016 14:10:46 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH v4 01/16] bluetooth: Switch SMP to crypto_cipher_encrypt_one() |
| |
On Thu, Jun 23, 2016 at 09:22:56PM -0700, Andy Lutomirski wrote: > SMP does ECB crypto on stack buffers. This is complicated and > fragile, and it will not work if the stack is virtually allocated. > > Switch to the crypto_cipher interface, which is simpler and safer. > > Cc: Marcel Holtmann <marcel@holtmann.org> > Cc: Gustavo Padovan <gustavo@padovan.org> > Cc: Johan Hedberg <johan.hedberg@gmail.com> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: linux-bluetooth@vger.kernel.org > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: netdev@vger.kernel.org > Signed-off-by: Andy Lutomirski <luto@kernel.org>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |