lkml.org 
[lkml]   [2016]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 11/27] perf tests time-to-tsc: No need to disable an event before deleting it
    Date
    From: Arnaldo Carvalho de Melo <acme@redhat.com>

    Because at the destructor we will call close() and that will do the
    disable. And we destructors can accept NULL, just like free(), so no
    need to check it.

    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Link: http://lkml.kernel.org/n/tip-i98mcyfkkjh5qp62dle27ac1@git.kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/arch/x86/tests/perf-time-to-tsc.c | 6 +-----
    1 file changed, 1 insertion(+), 5 deletions(-)

    diff --git a/tools/perf/arch/x86/tests/perf-time-to-tsc.c b/tools/perf/arch/x86/tests/perf-time-to-tsc.c
    index d4aa567a29c4..5c76cc83186a 100644
    --- a/tools/perf/arch/x86/tests/perf-time-to-tsc.c
    +++ b/tools/perf/arch/x86/tests/perf-time-to-tsc.c
    @@ -154,10 +154,6 @@ next_event:
    err = 0;

    out_err:
    - if (evlist) {
    - perf_evlist__disable(evlist);
    - perf_evlist__delete(evlist);
    - }
    -
    + perf_evlist__delete(evlist);
    return err;
    }
    --
    2.5.5
    \
     
     \ /
      Last update: 2016-06-24 00:21    [W:4.505 / U:0.368 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site