lkml.org 
[lkml]   [2016]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] bridge: netfilter: spanning tree: Add masked_ether_addr_equal and neatening
On Wed, Jun 15, 2016 at 01:58:45PM -0700, Joe Perches wrote:
> There is code duplication of a masked ethernet address comparison here
> so make it a separate function instead.
>
> Miscellanea:
>
> o Neaten alignment of FWINV macro uses to make it clearer for the reader

Applied, thanks.

> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>
> This masked_ether_addr_equal function could go into etherdevice.h,
> but I don't see another use like it in kernel code. Is there one?

This is specific of iptables, not even nftables would use this. So I
would keep this in the iptables tree.

\
 
 \ /
  Last update: 2016-06-23 20:01    [W:2.517 / U:0.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site