Messages in this thread | | | Date | Thu, 23 Jun 2016 19:36:59 +0200 | From | Pablo Neira Ayuso <> | Subject | Re: [PATCH] bridge: netfilter: spanning tree: Add masked_ether_addr_equal and neatening |
| |
On Wed, Jun 15, 2016 at 01:58:45PM -0700, Joe Perches wrote: > There is code duplication of a masked ethernet address comparison here > so make it a separate function instead. > > Miscellanea: > > o Neaten alignment of FWINV macro uses to make it clearer for the reader
Applied, thanks.
> Signed-off-by: Joe Perches <joe@perches.com> > --- > > This masked_ether_addr_equal function could go into etherdevice.h, > but I don't see another use like it in kernel code. Is there one?
This is specific of iptables, not even nftables would use this. So I would keep this in the iptables tree.
| |