Messages in this thread | | | From | Guenter Roeck <> | Date | Thu, 23 Jun 2016 10:23:49 -0700 | Subject | Re: [v3 PATCH 3/5] phy: Add USB Type-C PHY driver for rk3399 |
| |
Hi Chris,
[ ... ]
> + ret = extcon_register_notifier(tcphy->pd_extcon, EXTCON_USB, > + &tcphy->event_nb); > + if (ret) { > + dev_err(dev, "regitster EXTCON_USB notifer failed\n"); > + return ret; > + } > + > + ret = extcon_register_notifier(tcphy->pd_extcon, EXTCON_USB_HOST, > + &tcphy->event_nb); > + if (ret) { > + dev_err(dev, "regitster EXTCON_USB_HOST notifer failed\n"); > + return ret; > + } > + > + ret = extcon_register_notifier(tcphy->pd_extcon, EXTCON_DISP_DP, > + &tcphy->event_nb); > + if (ret) { > + dev_err(dev, "regitster EXTCON_DISP_DP notifer failed\n"); > + return ret; > + } > +
I don't think you can register multiple notifiers with the same notifier block. It may work by chance, but at least the 'next' object in notifier_clock is set in notifier_chain_register(). Best case it may work, but worst case it might cause a loop in the list of notifiers.
Guenter
| |