Messages in this thread | | | From | Sean Paul <> | Date | Thu, 23 Jun 2016 10:24:00 -0400 | Subject | Re: [PATCH v3 10/10] drm/bridge: analogix_dp: fix no drm hpd event when panel plug in |
| |
On Tue, Jun 14, 2016 at 7:46 AM, Yakir Yang <ykk@rock-chips.com> wrote: > The enum value of DP_IRQ_TYPE_HP_CABLE_IN is zero, but driver only > send drm hp event when the irq_type and the enum value is true. > > if (irq_type & DP_IRQ_TYPE_HP_CABLE_IN || ...) > drm_helper_hpd_irq_event(dp->drm_dev); > > So there would no drm hpd event when cable plug in, to fix that > just need to assign all hotplug enum with no-zero values. > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Yakir Yang <ykk@rock-chips.com> > Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> > Tested-by: Javier Martinez Canillas <javier@osg.samsung.com>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
> --- > Changes in v3: > - Add reviewed flag from Stéphane. > [https://chromium-review.googlesource.com/#/c/346319/15] > - Add tested flag from Javier > > Changes in v2: None > > drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h > index f09275d..b456380 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h > @@ -127,10 +127,10 @@ enum analog_power_block { > }; > > enum dp_irq_type { > - DP_IRQ_TYPE_HP_CABLE_IN, > - DP_IRQ_TYPE_HP_CABLE_OUT, > - DP_IRQ_TYPE_HP_CHANGE, > - DP_IRQ_TYPE_UNKNOWN, > + DP_IRQ_TYPE_HP_CABLE_IN = BIT(0), > + DP_IRQ_TYPE_HP_CABLE_OUT = BIT(1), > + DP_IRQ_TYPE_HP_CHANGE = BIT(2), > + DP_IRQ_TYPE_UNKNOWN = BIT(3), > }; > > struct video_info { > -- > 1.9.1 > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
| |