Messages in this thread | | | Date | Thu, 23 Jun 2016 16:00:28 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 02/11] x86/efi: Consolidate region mapping logic |
| |
On Thu, Jun 23, 2016 at 12:34:41PM +0100, Matt Fleming wrote: > EFI regions are currently mapped in two separate places. The bulk of > the work is done in efi_map_regions() but when CONFIG_EFI_MIXED is > enabled the additional regions that are required when operating in > mixed mode are mapping in efi_setup_page_tables(). > > Pull everything into efi_map_regions() and refactor the test for > which regions should be mapped into a should_map_region() function. > Generously sprinkle comments to clarify the different cases. > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Cc: Borislav Petkov <bp@alien8.de> > Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk> > --- > arch/x86/platform/efi/efi.c | 50 ++++++++++++++++++++++++++++++++++++------ > arch/x86/platform/efi/efi_64.c | 20 ----------------- > 2 files changed, 43 insertions(+), 27 deletions(-)
Looks good.
Acked-by: Borislav Petkov <bp@suse.de>
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply. --
| |