Messages in this thread | | | Subject | Re: [PATCH] wlcore: time sync : add support for 64 bit clock | From | Johannes Berg <> | Date | Thu, 23 Jun 2016 13:18:00 +0200 |
| |
On Thu, 2016-06-23 at 14:12 +0300, Yaniv Machani wrote: > Changed the configuration to support 64bit instead of 32bit > this in order to offload the driver from handling a wraparound.
[...]
Since you Cc'ed me, and presumably want me to review it, I'll say that this looks like a terrible idea:
> @@ -74,10 +74,16 @@ struct wl18xx_event_mailbox {
This struct is evidently used for firmware/host communication.
> __le16 bss_loss_bitmap; > > /* bitmap of stations (by HLID) which exceeded max tx > retries */ > - __le32 tx_retry_exceeded_bitmap; > + __le16 tx_retry_exceeded_bitmap; > + > + /* time sync high msb*/ > + u16 time_sync_tsf_high_msb;
So first of all, just using u16 instead of __le16 seems wrong.
Additionally, this looks like it changes the firmware API, so that older firmware images will no longer work?
johannes
| |