| From | Greg Kroah-Hartman <> | Subject | [PATCH 4.4 03/75] tipc: check nl sock before parsing nested attributes | Date | Wed, 22 Jun 2016 15:40:25 -0700 |
| |
4.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Richard Alpe <richard.alpe@ericsson.com>
[ Upstream commit 45e093ae2830cd1264677d47ff9a95a71f5d9f9c ]
Make sure the socket for which the user is listing publication exists before parsing the socket netlink attributes.
Prior to this patch a call without any socket caused a NULL pointer dereference in tipc_nl_publ_dump().
Tested-and-reported-by: Baozeng Ding <sploving1@gmail.com> Signed-off-by: Richard Alpe <richard.alpe@ericsson.com> Acked-by: Jon Maloy <jon.maloy@ericsson.cm> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- net/tipc/socket.c | 3 +++ 1 file changed, 3 insertions(+)
--- a/net/tipc/socket.c +++ b/net/tipc/socket.c @@ -2814,6 +2814,9 @@ int tipc_nl_publ_dump(struct sk_buff *sk if (err) return err; + if (!attrs[TIPC_NLA_SOCK]) + return -EINVAL; + err = nla_parse_nested(sock, TIPC_NLA_SOCK_MAX, attrs[TIPC_NLA_SOCK], tipc_nl_sock_policy);
|