lkml.org 
[lkml]   [2016]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [Y2038] [PATCH v2 09/24] fs: udf: Replace CURRENT_TIME with current_time()
Date
On Sunday, June 19, 2016 5:27:08 PM CEST Deepa Dinamani wrote:
> mutex_lock(&sbi->s_alloc_mutex);
> lvidiu->impIdent.identSuffix[0] = UDF_OS_CLASS_UNIX;
> lvidiu->impIdent.identSuffix[1] = UDF_OS_ID_LINUX;
> + ktime_get_real_ts(&ts);
> udf_time_to_disk_stamp(&lvid->recordingDateAndTime,
> - CURRENT_TIME);
> + timespec_trunc(ts, sb->s_time_gran));
> lvid->integrityType = cpu_to_le32(LVID_INTEGRITY_TYPE_OPEN);
>
> lvid->descTag.descCRC = cpu_to_le16(
>

I think we don't need the timespec_trunc here, and introducing the
call might complicate matters in the future.

IMHO timespec_trunc() really only makes sense when assigning into
an inode timestamp, whereas udf_time_to_disk_stamp() already truncates
the resulting nanoseconds to microseconds.

Arnd

\
 
 \ /
  Last update: 2016-06-22 16:41    [W:0.378 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site