Messages in this thread | | | Subject | Re: [PATCH 03/27] mm, vmscan: Move LRU lists to node | From | Vlastimil Babka <> | Date | Wed, 22 Jun 2016 14:50:57 +0200 |
| |
On 06/21/2016 04:15 PM, Mel Gorman wrote: > This moves the LRU lists from the zone to the node and related data > such as counters, tracing, congestion tracking and writeback tracking. > Unfortunately, due to reclaim and compaction retry logic, it is necessary > to account for the number of LRU pages on both zone and node logic. Most > reclaim logic is based on the node counters but the retry logic uses > the zone counters which do not distinguish inactive and inactive sizes. > It would be possible to leave the LRU counters on a per-zone basis but > it's a heavier calculation across multiple cache lines that is much > more frequent than the retry checks. > > Other than the LRU counters, this is mostly a mechanical patch but note > that it introduces a number of anomalies. For example, the scans are > per-zone but using per-node counters. We also mark a node as congested > when a zone is congested. This causes weird problems that are fixed later > but is easier to review. > > Signed-off-by: Mel Gorman <mgorman@techsingularity.net> > Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
| |