lkml.org 
[lkml]   [2016]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch V2 00/20] timer: Refactor the timer wheel
    B1;2802;0cOn Wed, 22 Jun 2016, Mike Galbraith wrote:
    > FWIW, testing with ltp, I noticed a new failure in logs. It turns out
    > to be intermittent, but the testcase mostly fails.

    You forgot to cc the LTP folks ...

    > rtbox:~ # /usr/local/ltp/conformance/interfaces/sigtimedwait/sigtimedwait_1-1.run-test
    > Test FAILED: sigtimedwait() did not return in the required time
    > time_elapsed: 1.197057
    > ...come on, you can do it...
    > rtbox:~ # /usr/local/ltp/conformance/interfaces/sigtimedwait/sigtimedwait_1-1.run-test
    > Test PASSED
    >
    > #define ERRORMARGIN 0.1
    > ...
    > if ((time_elapsed > SIGTIMEDWAITSEC + ERRORMARGIN)
    > || (time_elapsed < SIGTIMEDWAITSEC - ERRORMARGIN)) {
    > printf("Test FAILED: sigtimedwait() did not return in "
    > "the required time\n");
    > printf("time_elapsed: %lf\n", time_elapsed);
    > return PTS_FAIL;
    > }
    >
    > Looks hohum to me, but gripe did arrive with patch set, so you get a note.

    hohum is a euphemism. That's completely bogus.

    The only guarantee a syscall with timers has is: timer does not fire early.

    Thanks,

    tglx

    \
     
     \ /
      Last update: 2016-06-22 11:21    [W:5.037 / U:0.852 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site