lkml.org 
[lkml]   [2016]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [Y2038] [PATCH] crypto: use timespec64 for jent_get_nstime
Date
Am Dienstag, 21. Juni 2016, 10:12:24 schrieb John Stultz:

Hi John,
>
> So this is definitely more clear then what was described earlier, and
> worries me because on many x86 machines (though fewer I guess these
> days then in the past) the clocksource will often not be the TSC (and
> have lower resolution).

Please note, the use of the ktime_get_raw_ns() is *only* used as a fallback on
architectures where random_get_entropy / get_cycles is not implemented.

So, on X86 and on many other arches, this function call will never be
triggered.

...
>
> But please just make sure the reason why you're using that specific
> interface is clearly documented in the code so we don't have to later
> reverse engineer the intent.

Will do.

@Arnd: I would prepare a patch then using ktime_get_raw_ns and providing a
good documentation in the code.

Ciao
Stephan

\
 
 \ /
  Last update: 2016-06-21 20:01    [W:0.050 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site