lkml.org 
[lkml]   [2016]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 resend] libata:fix kernel panic when hotplug
Hello,

On Mon, Jun 20, 2016 at 06:46:55PM -0700, Dan Williams wrote:
> On Mon, Jun 20, 2016 at 6:22 PM, Martin K. Petersen
> <martin.petersen@oracle.com> wrote:
> >>>>>> "Tejun" == Tejun Heo <tj@kernel.org> writes:
> >
> >>> In fact,we don't need libata to deal with hotplug in sas environment.
> >>> So we can't run ata hotplug task when ata port is sas host.
> >
> > Tejun> Martin, can you please confirm whether the above is true. If so,
> > Tejun> I'll route the patch through libata w/ stable cc'd.
> >
> > Not exactly a libsas expert. James? Dan?
>
> While it is true that libsas itself handles adding / removing devices
> we have historically avoided this conflict because
> ATA_PFLAG_SCSI_HOTPLUG is never set for libsas ata_ports. So the bug
> / behavior change is that ATA_PFLAG_SCSI_HOTPLUG gets set in the
> first place. Ignoring it is a band-aid / not the real fix afaics.

I see. I'll hold off for now then. Ding Xiang, can you find out
where that flag is getting set?

Thanks!

--
tejun

\
 
 \ /
  Last update: 2016-06-21 18:21    [W:0.115 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site