Messages in this thread | | | Subject | Re: [PATCH v2] scsi: wd7000: print sector number as 64-bit | From | Joe Perches <> | Date | Tue, 21 Jun 2016 02:14:58 -0700 |
| |
On Tue, 2016-06-21 at 11:02 +0200, Arnd Bergmann wrote: > Enabling format checking in dprintk() shows that wd7000_biosparam > uses an incorrect format string for sector_t:
trivia:
> diff --git a/drivers/scsi/wd7000.c b/drivers/scsi/wd7000.c [] > @@ -192,7 +192,7 @@ > #ifdef WD7000_DEBUG > #define dprintk printk > #else > -#define dprintk(format,args...) > +#define dprintk no_printk > #endif
It'd be nicer if both defines were the same form
#ifdef WD7000_DEBUG #define dprintk printk #else #define dprintk no_printk #endif
| |