Messages in this thread | | | Subject | Re: [PATCH v9 2/4] power: reset: add reboot mode driver | From | Andy Yan <> | Date | Tue, 21 Jun 2016 14:16:43 +0800 |
| |
Hi Paul:
On 2016年06月20日 22:40, Paul Gortmaker wrote: > [Re: [PATCH v9 2/4] power: reset: add reboot mode driver] On 20/06/2016 (Mon 14:31) Krzysztof Kozlowski wrote: > >> On 06/20/2016 10:28 AM, Andy Yan wrote: >>> Hi Krzysztof: >>> >>> On 2016年06月20日 16:09, Krzysztof Kozlowski wrote: >>>> On 06/20/2016 08:38 AM, Andy Yan wrote: > [...] > >>>>> + >>>>> +config SYSCON_REBOOT_MODE >>>>> + bool "Generic SYSCON regmap reboot mode driver" >>>> Why not tristate? >>> I see many reset drivers in this directories use bool, so I follow >>> them. > Andy - understood, but mistakes done in the past do not justify > repeating them again in the present. OK, this is not strictly a mistake > in that it causes an error, but it isn't an ideal approach. > >> +Cc Paul, >> >> I don't mind that although I don't see any particular objections for >> making it module-capable. In the same time I just reminded myself about >> Paul Gortmaker's long effort (like [1] [2]) about removing module >> capability from non-modular drivers. > Thanks -- it is nice to see that people are starting to add this to > their review checklist ; early on they were getting added faster than I > could remove them. :-( But I think we are making ground now. > > For this case, I don't have any bias for it being built-in vs. being > modular, so long as the code is actually consistent with the Kconfig. > > For existing bool settings I just remove the modular references, since I > can't be extending the functionality to include a modular usage when I > can't test it or even be sure if a module has a sensible use case. > > Paul. > --
I will remove the module related stuff in the next version. >> Following his rationale, I think either this should be a tristate or the >> module stuff should be removed. >> >> Best regards, >> Krzysztof >> >> [1] https://lkml.org/lkml/2016/2/21/180 >> [2] https://lkml.org/lkml/2016/6/13/682 >> >> > >
| |