Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [RFC PATCH] x86: Move away from /dev/cpu/*/msr | Date | Mon, 20 Jun 2016 14:12:32 -0700 |
| |
Borislav Petkov <bp@alien8.de> writes:
> Comments are, as always, appreciated.
Seems like a waste of kernel code to me. The MSR interface works perfectly fine. There are potentially hundreds of useful MSRs, are you going to add new sysfs for each of them?
Even the more obscure ones can be very useful for debugging and monitoring.
Most MSRs are model specific so this would end up with tons of switch (x86_model) ... which are always difficult to maintain and need to be updated all the time when new CPUs come out.
This will likely generate a really large ongoing number of patches, and to solve what problem exactly?
The whole thing doesn't make any sense to me.
It's just a waste of code, maintainer time, patch review capacity, which all could be far more usefully employed to do something that actually solves real problems.
-Andi
-- ak@linux.intel.com -- Speaking for myself only
| |