Messages in this thread | | | Date | Mon, 20 Jun 2016 17:31:11 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH] x86/ptrace: Remove questionable TS_COMPAT usage in ptrace |
| |
On 06/19, Andy Lutomirski wrote: > > On Sun, Jun 19, 2016 at 2:19 PM, Oleg Nesterov <oleg@redhat.com> wrote: > > > > And this leads to another question, why do we actually need to set/clear > > TS_COMPAT in set_personality_ia32() ?? > > Something's clearly buggy there, considering that > set_personality_64bit() does *not* clear it.
Yes, yes, I too noticed this, and this doesn't match the "if (x32)" branch in set_personality_ia32().
But I think we do not really need to clear this bit. And probably set_personality_ia32() doesn't need to play with TS_COMPAT.
Oleg.
| |