lkml.org 
[lkml]   [2016]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v4 3/7] max8903: cleans up confusing relationship between dc_valid, dok and dcm.
    From
    Date
    On 06/20/2016 12:27 AM, Chris Lapa wrote:
    > From: Chris Lapa <chris@lapa.com.au>
    >
    > The max8903_charger.h file indicated that dcm and dok were not optional
    > when dc_valid is set.
    >
    > It makes sense to have dok as a compulsory pin when dc_valid is given.
    > However dcm can be optionally wired to a fixed level especially when the
    > circuit is configured for dc power exclusively.
    >
    > The previous implementation already allowed for this somewhat, however no
    > error was given if dok wasn't given whilst dc_valid was.
    >
    > The new implementation enforces dok presence when dc_valid is given. Whilst
    > allowing dcm to be optional.
    >
    > Signed-off-by: Chris Lapa <chris@lapa.com.au>

    Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

    BR.
    Krzysztof

    \
     
     \ /
      Last update: 2016-06-20 15:01    [W:4.783 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site