Messages in this thread | | | Date | Mon, 20 Jun 2016 19:21:57 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH] crypto : async implementation for sha1-mb |
| |
On Fri, Jun 17, 2016 at 12:28:30PM -0700, Megha Dey wrote: > > -static void sha1_mb_async_exit_tfm(struct crypto_tfm *tfm) > -{ > - struct sha1_mb_ctx *ctx = crypto_tfm_ctx(tfm); > + ahash_request_set_tfm(areq, child); > + ahash_request_set_callback(areq, CRYPTO_TFM_REQ_MAY_SLEEP, NULL, NULL);
You need to fix them all, not just the one that I picked out.
> @@ -874,11 +893,13 @@ static struct ahash_alg sha1_mb_async_alg = { > .cra_name = "sha1", > .cra_driver_name = "sha1_mb", > .cra_priority = 200, > - .cra_flags = CRYPTO_ALG_TYPE_AHASH | CRYPTO_ALG_ASYNC, > + .cra_flags = CRYPTO_ALG_TYPE_AHASH | > + CRYPTO_ALG_ASYNC,
Please don't include unrelated changes such as white-space fixes like this.
Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |