lkml.org 
[lkml]   [2016]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] gpio: add Intel WhiskeyCove GPIO driver
On Sun, Jun 19, 2016 at 08:54:32PM -0700, Bin Gao wrote:
> > > +#define DRV_NAME "bxt_wcove_gpio"
> >
> > Drop this.
> We have _TWO_ places using DRV_NAME(near the end of the file):
> static struct platform_driver wcove_gpio_driver = {
> .driver = {
> .name = DRV_NAME,
> },
>
> and
>
> MODULE_ALIAS("platform:" DRV_NAME);
>
> You are suggesting to replace DRV_NAME with bxt_wcove_gpio(but why?)
> or something else?

Do instead this:

.driver = {
.name ="bxt_wcove_gpio",
},

and

MODULE_ALIAS("platform:bxt_wcove_gpio");

\
 
 \ /
  Last update: 2016-06-20 10:01    [W:0.407 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site