lkml.org 
[lkml]   [2016]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] vmd: use untracked irq handler
    On Fri, Jun 17, 2016 at 04:00:21PM -0600, Keith Busch wrote:
    > There is no way to know which device in a VMD tiggered an interrupt

    s/tiggered/triggered/

    > without invoking every registered driver's actions. This uses the
    > untracked irq handler so that a less used device does not trigger
    > spurious interrupt.
    >
    > We have been previously recommending users enable "noirqdebug", but do
    > not want to force a system setting just to keep this domain functional.

    I applaud that goal.

    > Signed-off-by: Keith Busch <keith.busch@intel.com>

    Since this depends on the previous patch and I'm not qualified to review
    that one, I'll ack this and somebody else can merge both or none:

    Acked-by: Bjorn Helgaas <bhelgaas@google.com>

    > ---
    > arch/x86/pci/vmd.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/arch/x86/pci/vmd.c b/arch/x86/pci/vmd.c
    > index 7792aba..613cac7 100644
    > --- a/arch/x86/pci/vmd.c
    > +++ b/arch/x86/pci/vmd.c
    > @@ -195,7 +195,7 @@ static int vmd_msi_init(struct irq_domain *domain, struct msi_domain_info *info,
    > vmdirq->virq = virq;
    >
    > irq_domain_set_info(domain, virq, vmdirq->irq->vmd_vector, info->chip,
    > - vmdirq, handle_simple_irq, vmd, NULL);
    > + vmdirq, handle_untracked_irq, vmd, NULL);
    > return 0;
    > }
    >
    > --
    > 2.7.2
    >

    \
     
     \ /
      Last update: 2016-06-18 01:21    [W:3.886 / U:0.440 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site