lkml.org 
[lkml]   [2016]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND RFT PATCH 1/2] mfd: max14577: Use module_init() instead of subsys_initcall()
On Thu, 26 May 2016, Javier Martinez Canillas wrote:

> The driver's init function is called at subsys init call level but the
> dependencies provided by the driver are looked up by drivers that have
> probe deferral support, so manual ordering of init calls isn't needed.
>
> Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
> Hello,
>
> I checked an the only users in mainline for this driver are the Exynos3250
> Monk and Rinato boards. In both, only two regulators are used (safeout_reg
> and motor_reg) and these are looked up by the drivers phy-samsung-usb2 and
> regulator-haptic respectively, and both support probe deferral.
>
> Best regards,
> Javier
>
> drivers/mfd/max14577.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c
> index 2280b3fdcf68..6c245128ab2e 100644
> --- a/drivers/mfd/max14577.c
> +++ b/drivers/mfd/max14577.c
> @@ -561,7 +561,7 @@ static int __init max14577_i2c_init(void)
>
> return i2c_add_driver(&max14577_i2c_driver);
> }
> -subsys_initcall(max14577_i2c_init);
> +module_init(max14577_i2c_init);
>
> static void __exit max14577_i2c_exit(void)
> {

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2016-06-16 13:21    [W:0.057 / U:0.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site