Messages in this thread Patch in this message | | | Date | Thu, 16 Jun 2016 01:32:07 -0700 | From | tip-bot for Masami Hiramatsu <> | Subject | [tip:perf/core] perf probe: Fix to add NULL check for strndup |
| |
Commit-ID: 844faa4bcddc5d321311003ea3af9d808371c48e Gitweb: http://git.kernel.org/tip/844faa4bcddc5d321311003ea3af9d808371c48e Author: Masami Hiramatsu <mhiramat@kernel.org> AuthorDate: Wed, 8 Jun 2016 18:29:21 +0900 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Tue, 14 Jun 2016 09:29:54 -0300
perf probe: Fix to add NULL check for strndup
Fix to add a NULL check for strndup when parsing probe trace command.
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org> Cc: Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com> Cc: Brendan Gregg <brendan.d.gregg@gmail.com> Cc: Hemant Kumar <hemant@linux.vnet.ibm.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/20160608092920.3116.63319.stgit@devbox Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/probe-event.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index 74401a2..7ae3dd1 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -1603,6 +1603,10 @@ int parse_probe_trace_command(const char *cmd, struct probe_trace_event *tev) p = strchr(argv[1], ':'); if (p) { tp->module = strndup(argv[1], p - argv[1]); + if (!tp->module) { + ret = -ENOMEM; + goto out; + } p++; } else p = argv[1];
| |