Messages in this thread | | | Subject | Re: [PATCH] [media] v4l2-ioctl.c: fix warning due wrong check in v4l_cropcap() | From | Javier Martinez Canillas <> | Date | Wed, 15 Jun 2016 08:09:37 -0400 |
| |
Hello Hans,
On 06/15/2016 02:09 AM, Hans Verkuil wrote: > On 06/14/2016 10:18 PM, Javier Martinez Canillas wrote: >> Commit 95dd7b7e30f3 ("[media] v4l2-ioctl.c: improve cropcap compatibility >> code") tried to check if both .vidioc_cropcap and .vidioc_g_selection are >> NULL ops and warn if that was the case, but unfortunately the logic isn't >> correct and instead checks for .vidioc_cropcap == NULL twice. >> >> So the v4l2 core will print the following warning if a driver has the ops >> .vidioc_g_selection set but no .vidioc_cropcap callback: > > This fix is already queued up for 4.7. >
Thanks, and sorry for missing that you already had a fix queued for this.
> Regards, > > Hans > >>
Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
| |