lkml.org 
[lkml]   [2016]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/15] drivers: net: cpsw: check return code from pm runtime calls
    Date
    Add missed check of return codes from PM runtime get() calls.

    Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
    ---
    drivers/net/ethernet/ti/cpsw.c | 12 ++++++++++--
    1 file changed, 10 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
    index 736c77a..c76f9db 100644
    --- a/drivers/net/ethernet/ti/cpsw.c
    +++ b/drivers/net/ethernet/ti/cpsw.c
    @@ -1253,7 +1253,11 @@ static int cpsw_ndo_open(struct net_device *ndev)
    int i, ret;
    u32 reg;

    - pm_runtime_get_sync(&priv->pdev->dev);
    + ret = pm_runtime_get_sync(&priv->pdev->dev);
    + if (ret < 0) {
    + pm_runtime_put_noidle(&priv->pdev->dev);
    + return ret;
    + }

    if (!cpsw_common_res_usage_state(priv))
    cpsw_intr_disable(priv);
    @@ -2322,7 +2326,11 @@ static int cpsw_probe(struct platform_device *pdev)
    /* Need to enable clocks with runtime PM api to access module
    * registers
    */
    - pm_runtime_get_sync(&pdev->dev);
    + ret = pm_runtime_get_sync(&pdev->dev);
    + if (ret < 0) {
    + pm_runtime_put_noidle(&pdev->dev);
    + goto clean_runtime_disable_ret;
    + }
    priv->version = readl(&priv->regs->id_ver);
    pm_runtime_put_sync(&pdev->dev);

    --
    2.8.4
    \
     
     \ /
      Last update: 2016-06-15 14:41    [W:3.067 / U:0.476 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site