lkml.org 
[lkml]   [2016]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC PATCH] tty: serial: msm_serial: Don't reset uart on set_termios
    From
    Date
    On 06/13/2016 12:02 PM, Bjorn Andersson wrote:
    > Upon opening the tty, uart_open() ends up calling msm_set_baud_rate()
    > which resets the uart block. If this happens as we're coming out of
    > msm_console_write() a full fifo worth of console output will be
    > discarded.
    >
    > Cc: Stephen Boyd <sboyd@codeaurora.org>
    > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    > ---
    >
    > As reported here:
    > https://bugs.96boards.org/show_bug.cgi?id=378

    Urgh. As mentioned in commit a12f1b406f2d (tty: serial: msm: Reset
    uartdm after baud rate change, 2014-10-29) we actually need to reset the
    hardware sometimes. Perhaps as discussed over IRC we need to take a
    different approach here and only reset the hardware if the baud actually
    changes? One way to test this would be to try running a getty on the
    console and see if input still works.

    --
    Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
    a Linux Foundation Collaborative Project

    \
     
     \ /
      Last update: 2016-06-16 03:41    [W:3.639 / U:0.604 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site