Messages in this thread | | | Date | Tue, 14 Jun 2016 23:46:58 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH v2 net-next v2 10/12] net: dsa: mv88e6xxx: iterate on compatible info |
| |
On Tue, Jun 14, 2016 at 02:31:51PM -0400, Vivien Didelot wrote: > With legacy probing, we cannot have a compatible info structure. We have > to guess it. Instead of using only the first info structure of the info > table, iterate over the compatible data. > > That way, the legacy code will support new compatible chips with > different register access without requiring any code change.
I don't think this is safe when used in combination with multi-chip addresses. This code will perform writes on various addresses, addresses which could be real registers on a device.
I don't see a need to support guessing. The new binding will work, without any guessing. So use that.
Andrew
| |