lkml.org 
[lkml]   [2016]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] scripts/gdb: Perform path expansion to lx-symbol's arguments
From
Date


On 13/06/16 07:18, Jan Kiszka wrote:
> On 2016-06-08 18:28, Nikolay Borisov wrote:
>> Python doesn't do automatic expansion of paths. In case one passes
>> path of the from ~/foo/bar the gdb scripts won't automatically expand
>> that and as a result the symbols files won't be loaded. Fix this
>> by explicitly expanding all paths which begin with "~"
>>
>> Signed-off-by: Nikolay Borisov <n.borisov.lkml@gmail.com>
>> ---
>> scripts/gdb/linux/symbols.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/gdb/linux/symbols.py b/scripts/gdb/linux/symbols.py
>> index 9a0f8923f67c..004b0ac7fa72 100644
>> --- a/scripts/gdb/linux/symbols.py
>> +++ b/scripts/gdb/linux/symbols.py
>> @@ -153,7 +153,7 @@ lx-symbols command."""
>> saved_state['breakpoint'].enabled = saved_state['enabled']
>>
>> def invoke(self, arg, from_tty):
>> - self.module_paths = arg.split()
>> + self.module_paths = [os.path.expanduser(p) for p in arg.split()]
>> self.module_paths.append(os.getcwd())
>>
>> # enforce update
>>
>
> Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
>
> Kieran, will you take this, as you are already preparing other patches?

Yes, that should be fine.

> Thanks,
> Jan
>

--
Regards

Kieran Bingham

\
 
 \ /
  Last update: 2016-06-13 11:41    [W:0.126 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site