Messages in this thread | | | Date | Sun, 12 Jun 2016 13:13:38 +0200 | From | Lukas Wunner <> | Subject | Re: [tip:x86/urgent] x86/quirks: Add early quirk to reset Apple AirPort card |
| |
On Fri, Jun 10, 2016 at 03:08:02PM -0500, Bjorn Helgaas wrote: > On Fri, Jun 10, 2016 at 03:59:04PM +0200, Lukas Wunner wrote: > > On Fri, Jun 10, 2016 at 02:59:57PM +0200, Ingo Molnar wrote: > > > So I'd lean towards lower complexity, but since this is essentially > > > PCI code I'd like to defer to Bjorn on that detail. > > Since you asked my opinion, here it is, but it's probably more than > you wanted :)
That is one sublime review. Thanks a lot.
I've just posted v2, taking into account all of Bjorn's suggestions: https://lkml.org/lkml/2016/6/12/65
@Ingo Molnar: I noticed that you've removed the line breaks in read/write_pci_config_16(). I've carried that change over to v2 even though it exceeds 80 chars/line and thus doesn't seem to comply with Documentation/CodingStyle, chapter 2.
Please note that the stable designation in patch [3/3] needs to be amended with the sha1 of the two preceding patches after they have been merged.
Thanks again & best regards,
Lukas
| |