Messages in this thread | | | Subject | Re: [PATCH V6 7/8] vfio: platform: check reset call return code during open | From | Sinan Kaya <> | Date | Sun, 12 Jun 2016 23:12:41 -0400 |
| |
On 6/7/2016 4:21 PM, Auger Eric wrote: >> - vfio_platform_call_reset(vdev, NULL); >> > + ret = vfio_platform_call_reset(vdev, &extra_dbg); >> > + if (ret && vdev->reset_required) { >> > + dev_warn(vdev->device, "reset driver is required and reset call failed in open (%d) %s\n", >> > + ret, extra_dbg ? extra_dbg : ""); >> > + goto err_irq; > I am afraid you need to tear down the resources allocated by vfio_platform_irq_init. > > Best Regards > > Eric
I added this to the error path and replaced the goto above with err_rst.
+err_rst: + vfio_platform_irq_cleanup(vdev); err_irq: vfio_platform_regions_cleanup(vdev);
-- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |