lkml.org 
[lkml]   [2016]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 44/46] net: fix infoleak in llc
    3.2.81-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Kangjie Lu <kangjielu@gmail.com>

    commit b8670c09f37bdf2847cc44f36511a53afc6161fd upstream.

    The stack object “info” has a total size of 12 bytes. Its last byte
    is padding which is not initialized and leaked via “put_cmsg”.

    Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    net/llc/af_llc.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/net/llc/af_llc.c
    +++ b/net/llc/af_llc.c
    @@ -627,6 +627,7 @@ static void llc_cmsg_rcv(struct msghdr *
    if (llc->cmsg_flags & LLC_CMSG_PKTINFO) {
    struct llc_pktinfo info;

    + memset(&info, 0, sizeof(info));
    info.lpi_ifindex = llc_sk(skb->sk)->dev->ifindex;
    llc_pdu_decode_dsap(skb, &info.lpi_sap);
    llc_pdu_decode_da(skb, info.lpi_mac);
    \
     
     \ /
      Last update: 2016-06-13 00:21    [W:4.215 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site