lkml.org 
[lkml]   [2016]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/2] acpi/pmic: Add opregion driver for Intel BXT WhiskeyCove PMIC
    From
    Date
    On 06/11/2016 03:25 PM, Bin Gao wrote:
    > This patch adds operation region driver for Intel BXT WhiskeyCove
    > PMIC. The register mapping is done as per the BXT WC data sheet.
    >
    > Signed-off-by: Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>
    > Signed-off-by: Bin Gao <bin.gao@intel.com>
    > ---
    > +static int __init intel_bxtwc_pmic_opregion_driver_init(void)
    > +{
    > + return platform_driver_register(&intel_bxtwc_pmic_opregion_driver);
    > +}
    > +
    > +module_init(intel_bxtwc_pmic_opregion_driver_init);

    Last time Paul suggests device_initcall instead of module_init here:

    commit 75829dcf10862966f52716f2d67ac1c1b1eb486b
    Author: Paul Gortmaker <paul.gortmaker@windriver.com>
    Date: Mon Feb 15 00:27:51 2016 -0500

    drivers/acpi: make pmic/intel_pmic_crc.c explicitly non-modular

    Perhaps you should do the same.

    Thanks,
    Aaron

    > +
    > +MODULE_DESCRIPTION("BXT WhiskeyCove ACPI opregion driver");
    > +MODULE_LICENSE("GPL");
    >

    \
     
     \ /
      Last update: 2016-06-12 05:01    [W:6.953 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site