lkml.org 
[lkml]   [2016]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] apparmor: do not expose kernel stack
From
Date
On 06/10/2016 02:34 PM, Heinrich Schuchardt wrote:
> Do not copy uninitalized fields th.td_hilen, th.td_data.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Acked-by: John Johansen <john.johansen@canonical.com>

I have a queue of patches I need to push this weekend so I
will suck this one in and send it up with the rest

> ---
> security/apparmor/match.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/security/apparmor/match.c b/security/apparmor/match.c
> index 727eb42..1d6dbd8 100644
> --- a/security/apparmor/match.c
> +++ b/security/apparmor/match.c
> @@ -61,7 +61,9 @@ static struct table_header *unpack_table(char *blob, size_t bsize)
>
> table = kvzalloc(tsize);
> if (table) {
> - *table = th;
> + table->td_id = th.td_id;
> + table->td_flags = th.td_flags;
> + table->td_lolen = th.td_lolen;
> if (th.td_flags == YYTD_DATA8)
> UNPACK_ARRAY(table->td_data, blob, th.td_lolen,
> u8, byte_to_byte);
>

\
 
 \ /
  Last update: 2016-06-11 00:21    [W:0.034 / U:0.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site