lkml.org 
[lkml]   [2016]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] PCI: Use device_match_always()
On Fri, Jun 10, 2016 at 11:13:43AM -0500, Bjorn Helgaas wrote:
> On Mon, Jun 06, 2016 at 09:32:37AM +0200, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > There is now a common implementation for a match function that will
> > always match, so the PCI-specific implementation can be removed.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>
> I'm sort of OK with this. It's clearly not going to break anything.
>
> But I would far rather figure out a way to remove no_pci_devices()
> completely. There's only one in-tree caller, and it's sort of
> dubious, although the idea was added by Linus (2bff5e94f1bf).

This is sort of a spin-off from another series that I sent out, which
introduced a common function that was used in far more places and has
a more clearly legitimate use. While working on that other series the
duplication here occurred to me, so I thought I'd remove it while at
it, even if there are only two occurrences.

> I suppose nowadays we would use ACPI or DMI to do this. But I guess
> this is OK as-is. It'd be pretty hard to find a PC110 to test any
> real driver changes.
>
> I assume all three of these patches would get merged together by
> somebody else.

I was thinking Greg could take them through the driver core tree.

Thierry
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-06-10 19:21    [W:0.047 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site