Messages in this thread | | | From | Doug Anderson <> | Date | Fri, 10 Jun 2016 09:11:30 -0700 | Subject | Re: [PATCH v2 6/6] drm/panel: simple: Add support for Sharp LQ123P1JX31 2400x1600 panel |
| |
Hi,
On Wed, Jun 8, 2016 at 9:35 AM, Doug Anderson <dianders@chromium.org> wrote: > Yakir, > > On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang <ykk@rock-chips.com> wrote: >> The Sharp LQ123P1JX31 is an 12.3", 2400x1600 TFT-LCD panel connected >> using eDP interfaces. >> >> Signed-off-by: Yakir Yang <ykk@rock-chips.com> >> --- >> Changes in v2: >> - Add detail timing of Sharp LQ123P1JX31 panel in v2 >> >> drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) > > Looks good to me. Values in the table match the EDID I see from this > panel and everything else looks to be in order. > > Reviewed-by: Doug Anderson <dianders@chromium.org> > Tested-by: Doug Anderson <dianders@chromium.org>
Sorry for not noticing. :( ...but as others have pointed out for your earlier patches, the size is incorrect. I found the correct size and it should be:
.width = 259, .height = 173,
-Doug
| |