lkml.org 
[lkml]   [2016]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 6/6] drm/panel: simple: Add support for Sharp LQ123P1JX31 2400x1600 panel
Hi,

On Wed, Jun 8, 2016 at 9:35 AM, Doug Anderson <dianders@chromium.org> wrote:
> Yakir,
>
> On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang <ykk@rock-chips.com> wrote:
>> The Sharp LQ123P1JX31 is an 12.3", 2400x1600 TFT-LCD panel connected
>> using eDP interfaces.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> ---
>> Changes in v2:
>> - Add detail timing of Sharp LQ123P1JX31 panel in v2
>>
>> drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>
> Looks good to me. Values in the table match the EDID I see from this
> panel and everything else looks to be in order.
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> Tested-by: Doug Anderson <dianders@chromium.org>

Sorry for not noticing. :( ...but as others have pointed out for
your earlier patches, the size is incorrect. I found the correct size
and it should be:

.width = 259,
.height = 173,


-Doug

\
 
 \ /
  Last update: 2016-06-10 18:41    [W:0.665 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site