lkml.org 
[lkml]   [2016]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v8 2/5] perf config: Bring declarations about config from util/cache.h to util/config.h
From
Date
Hi, Arnaldo :)

Thank you for your review.

On 06/09/2016 10:29 PM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jun 08, 2016 at 09:36:50PM +0900, Taeung Song escreveu:
>> Lately util/config.h has been added
>> but util/cache.h has declarations of functions
>> and extern variable for config features.
>>
>> To manage codes about configuration at one spot, move them
>> to util/config.h and util/cache.h include util/config.h
>>
>> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
>> Cc: Jiri Olsa <jolsa@redhat.com>
>> Cc: Masami Hiramatsu <mhiramat@kernel.org>
>> Cc: Namhyung Kim <namhyung@kernel.org>
>> Cc: Wang Nan <wangnan0@huawei.com>
>> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
>> ---
>> tools/perf/util/cache.h | 13 +------------
>> tools/perf/util/config.h | 12 ++++++++++++
>> 2 files changed, 13 insertions(+), 12 deletions(-)
>>
>> diff --git a/tools/perf/util/cache.h b/tools/perf/util/cache.h
>> index 0d814bb..cd8cd4d 100644
>> --- a/tools/perf/util/cache.h
>> +++ b/tools/perf/util/cache.h
>> @@ -7,6 +7,7 @@
>> #include <subcmd/pager.h>
>> #include "../perf.h"
>> #include "../ui/ui.h"
>> +#include "config.h"
>
> Why have you added that? Are those config functions used in cache.h?
>

Yes, it does. Many source files include cache.h
e.g. builtin-annoate.c, util/color.c, builtin-report.c and etc.
And They can use perf_config() function including this header file.

So, If I totally eliminate not only declarations about config
but also #include "util/config.h" at util/cache.h,
we should add '#include "util/config.h"' to each source file that
need perf_config() overall.

But IMHO, if cache.h include config.h,
we don't need to find source files that use perf_config().

Thanks,
Taeung

\
 
 \ /
  Last update: 2016-06-10 09:01    [W:0.140 / U:0.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site