Messages in this thread | | | Subject | Re: [PATCH 1/2] max8903: adds support for initiation via device tree. | From | Krzysztof Kozlowski <> | Date | Fri, 10 Jun 2016 12:23:46 +0200 |
| |
On 06/10/2016 08:13 AM, Krzysztof Kozlowski wrote: > On 06/10/2016 07:35 AM, Chris Lapa wrote: >> Hi Krzysztof, >> >> Thanks for the review. I'm working on those changes now. >> >> However just so I know for the future. Why no error checking on >> devm_kzalloc() result? Looking through the source for devm_kzalloc() it >> looks like NULL isn't caught anywhere else. > > Error checking is necessary. Just do not print the error message. The > kernel core will print one with full back trace. > > if (charger == NULL) > return -ENOMEM;
... and while at it just convert it to simpler: if (!charger) return -ENOMEM;
BR, Krzysztof
| |