lkml.org 
[lkml]   [2016]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] usb: dwc3: fix runtime PM in error path
From
Date
On 10/06/16 12:16, Felipe Balbi wrote:
>
> Hi,
>
> Roger Quadros <rogerq@ti.com> writes:
>> If there is a failure after pm_runtime_enable/get_sync()
>> we need to call pm_runtime_disable/put_sync().
>>
>> Otherwise it will lead to an unbalanced pm_runtime_enable() on the
>> subsequent probe if the earlier probe bailed out due to -EPROBE_DEFER.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>
> where is this supposed to be applied? You're not checking if

On your testing/next

> pm_runtime_get() failed at all.
>

I'm not adding pm_runtime_get in my patch.
Just fixing up the failure path in core.c.

cheers,
-roger

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-06-10 12:21    [W:0.114 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site