Messages in this thread | | | From | John Stultz <> | Subject | [PATCH 0/2 v2] Fix for settimeofday() error checking regression | Date | Wed, 1 Jun 2016 11:53:25 -0700 |
| |
As reported by Mika Westerberg here: https://lkml.org/lkml/2016/5/30/413
A regression in the settimeofday error checking snuck in via 86d3473224b0 ("time: Introduce do_sys_settimeofday64()"), effecting cases where the timeval is null but the timezone was set.
This patchset contains my proposed fix and an addition to the kselftests to add checks for this case.
Thomas: Can you please queue the first patch in tip/timers/urgent?
Shuah: I'll leave the second patch to your discretion.
thanks -john
v2: * Add logic simplification suggested by Dima Stepanov * Add tested by tag from Mika
Cc: Mika Westerberg <mika.westerberg@linux.intel.com> Cc: Baolin Wang <baolin.wang@linaro.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Shuah Khan <shuahkh@osg.samsung.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Ingo Molnar <mingo@kernel.org> Cc: Richard Cochran <richardcochran@gmail.com> Cc: Prarit Bhargava <prarit@redhat.com>
John Stultz (2): time: Fix problematic change in settimeofday error checking kselftests: timers: Add set-tz test case
include/linux/timekeeping.h | 3 + tools/testing/selftests/timers/Makefile | 3 +- tools/testing/selftests/timers/set-tz.c | 119 ++++++++++++++++++++++++++++++++ 3 files changed, 124 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/timers/set-tz.c
-- 1.9.1
| |