Messages in this thread | | | Date | Wed, 1 Jun 2016 13:49:39 +0300 | From | Mika Westerberg <> | Subject | Re: [RFC][PATCH 1/2] time: Fix problematic change in settimeofday error checking |
| |
On Tue, May 31, 2016 at 02:32:14PM -0700, John Stultz wrote: > In commit 86d3473224b0 ("time: Introduce do_sys_settimeofday64()") > some of the checking for a valid timeval was subtley changed > which caused -EINVAL to be returned whenever the timeval was null. > > However, it is possible to set the timezone data while specifying > a NULL timeval, which is usually done to handle systems where the > RTC keeps local time instead of UTC. Thus the patch causes such > systems to have the time incorrectly set. > > This patch addresses the issue by handling the error conditionals > in the same way as was done previously. > > Cc: Mika Westerberg <mika.westerberg@linux.intel.com> > Cc: Baolin Wang <baolin.wang@linaro.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Shuah Khan <shuahkh@osg.samsung.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Ingo Molnar <mingo@kernel.org> > Cc: Richard Cochran <richardcochran@gmail.com> > Cc: Prarit Bhargava <prarit@redhat.com> > Reported-by: Mika Westerberg <mika.westerberg@linux.intel.com>
I can confirm that this patch fixes the issue I'm seeing. Thanks!
Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
| |