Messages in this thread | | | Subject | Re: [PATCH v2 2/3] net: ethernet: fec: use phydev from struct net_device | From | Ben Hutchings <> | Date | Mon, 09 May 2016 00:01:23 +0100 |
| |
On Mon, 2016-05-09 at 00:47 +0200, Philippe Reynes wrote: > On 09/05/16 00:22, Ben Hutchings wrote: > > > > On Sun, 2016-05-08 at 23:44 +0200, Philippe Reynes wrote: > > > > > > The private structure contain a pointer to phydev, but the structure > > > net_device already contain such pointer. So we can remove the pointer > > > phydev in the private structure, and update the driver to use the one > > > contained in struct net_device. > > But there is no central code that updates the pointer, so: > The function phy_attach_direct and phy_detach update the pointer > phydev in the struct net_device. [...] > So from my understanding, those two lines aren't usefull. > May you confirm that I'm on the right way please ?
Sorry, you're right.
Ben.
-- Ben Hutchings I haven't lost my mind; it's backed up on tape somewhere.[unhandled content-type:application/pgp-signature] | |