Messages in this thread | | | Subject | Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings | From | Ben Hutchings <> | Date | Sat, 07 May 2016 12:59:57 +0100 |
| |
On Sat, 2016-05-07 at 01:18 +0200, Philippe Reynes wrote: > The callback {get|set}_link_ksettings are often defined > in a very close way. There are mainly two differences in > those callback: > - the name of the netdev private structure > - the name of the struct phydev in the private structure > > We add two defines ethtool_phy_{get|set}_link_ksettings > to avoid writing severals times almost the same function. [...]
I don't think there's no need to access a private structure, as there's a phydev pointer in struct net_device. If some drivers don't maintain that pointer, they should be changed to do so. Then they can use generic implementations of {get,set}_link_ksettings provided by phylib.
Ben.
-- Ben Hutchings Editing code like this is akin to sticking plasters on the bleeding stump of a severed limb. - me, 29 June 1999[unhandled content-type:application/pgp-signature] | |